[webkit-reviews] review granted: [Bug 237342] Mousemove events double-firing in Safari : [Attachment 453612] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 237342: Mousemove events double-firing in Safari
https://bugs.webkit.org/show_bug.cgi?id=237342

Attachment 453612: Patch

https://bugs.webkit.org/attachment.cgi?id=453612&action=review




--- Comment #5 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 453612
  --> https://bugs.webkit.org/attachment.cgi?id=453612
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453612&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:696
> +- (void)_simulateMouseMove:(NSEvent *)event;

Let's move this to WKWebViewPrivateForTestingMac.h instead.

> Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:185
> +    WebKit::WebViewImpl* _impl;

In modern code, ObjC ivars should go into the @implementation.

I think ideally, this would also be a WeakPtr instead of a raw pointer.

> Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:191
> +- (instancetype)initWithViewImpl:(WebKit::WebViewImpl *)impl

I think we would prefer to take WebKit::WebViewImpl& here if we don't expect to
pass `nullptr`.