[webkit-reviews] review granted: [Bug 237359] Scope capture sources by page identifiers : [Attachment 453596] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 237359: Scope capture sources by page identifiers
https://bugs.webkit.org/show_bug.cgi?id=237359

Attachment 453596: Patch

https://bugs.webkit.org/attachment.cgi?id=453596&action=review




--- Comment #8 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 453596
  --> https://bugs.webkit.org/attachment.cgi?id=453596
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453596&action=review

> Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:328
> +	       if (mediaConstraints) {
> +		   auto error = source->applyConstraints(*mediaConstraints);
> +		   if (error)
> +		       return WTFMove(error->message);
> +	       }

It would be nice to improve this eventually so we apply a union of the
constraints, so we always capture at the highest requested constraint values
and decimate/downsample as necessary. Maybe add a FIXME?

> Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:343
> +#if PLATFORM(IOS_FAMILY)
> +    if (perPageSources.cameraSource) {
> +	   // We cannot reuse the source so fail it.
> +	   perPageSources.cameraSource->captureFailed();
> +	   perPageSources.cameraSource->stop();
> +    }
> +#endif

I would be cleaner to have the compile flag in a method
(`canCaptureFromMultipleCameras`?).