[webkit-reviews] review granted: [Bug 237042] fast/mediastream/getUserMedia-to-canvas-1.html and fast/mediastream/getUserMedia-to-canvas-2.html are failing on MacOS when remote video frame flag is enabled : [Attachment 453481] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 237042: fast/mediastream/getUserMedia-to-canvas-1.html and
fast/mediastream/getUserMedia-to-canvas-2.html are failing on MacOS when remote
video frame flag is enabled
https://bugs.webkit.org/show_bug.cgi?id=237042

Attachment 453481: Patch

https://bugs.webkit.org/attachment.cgi?id=453481&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 453481
  --> https://bugs.webkit.org/attachment.cgi?id=453481
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453481&action=review

> LayoutTests/ChangeLog:3
> +	   fast/mediastream/getUserMedia-to-canvas-1.html and
fast/mediastream/getUserMedia-to-canvas-2.html are failing on MacOS when remote
video frame flag is enabled

Nit: It would be nice to wrap the very long lines in this ChangeLog so they are
easier to read on a small screen

> LayoutTests/ChangeLog:9
> +	   Video element videoWidth/videoHeight are updated when track settings
are changed, and not according video frames being received.

s/not according video frames being/not when video frames are/