[webkit-reviews] review granted: [Bug 237318] Remove RemoteVideoSample support from ImageTransferSessionVT : [Attachment 453491] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 237318: Remove RemoteVideoSample support from ImageTransferSessionVT
https://bugs.webkit.org/show_bug.cgi?id=237318

Attachment 453491: Patch

https://bugs.webkit.org/attachment.cgi?id=453491&action=review




--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 453491
  --> https://bugs.webkit.org/attachment.cgi?id=453491
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453491&action=review

> Source/WebKit/WebProcess/cocoa/RemoteCaptureSampleManager.cpp:269
> +    auto videoFrame =
MediaSampleAVFObjC::createImageSample(WTFMove(pixelBuffer),
remoteSample.rotation(), remoteSample.mirrored(), remoteSample.time());

As a followup, I think `MediaSampleAVFObjC::createImageSample` is a slightly
confusing name. Maybe something like
`MediaSampleAVFObjC::createFromPixelBuffer` would be clearer?