[webkit-reviews] review granted: [Bug 235476] [CMake] Stop defaulting to ld.gold : [Attachment 450410] Patch v3

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at gnome.org> has granted Adrian Perez
<aperez at igalia.com>'s request for review:
Bug 235476: [CMake] Stop defaulting to ld.gold
https://bugs.webkit.org/show_bug.cgi?id=235476

Attachment 450410: Patch v3

https://bugs.webkit.org/attachment.cgi?id=450410&action=review




--- Comment #16 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 450410
  --> https://bugs.webkit.org/attachment.cgi?id=450410
Patch v3

View in context: https://bugs.webkit.org/attachment.cgi?id=450410&action=review

> Source/cmake/OptionsCommon.cmake:134
> +    # Check wether the linker supports --gdb-index. Use try_compile()
directly

whether

> Source/cmake/OptionsCommon.cmake:138
> +	   "int main(int argc, char** argv) { (void) argc; (void) argv; return
0; }")

You can simplify this by writing "int main(void)"

> ChangeLog:17
> +	   While at it, also feature check whether the linker supports thin
archives, in order
> +	   to enable them only when actually usable. This avoids situations in
which thin archives
> +	   can be created by the archiver but later on the linker will not be
able to consume them.

This is really far removed from ld.gold -> ld.bfd. Please split it out into a
separate bug. r=me applies to the ld.gold changes. I haven't devoted enough
brainpower to think about the thin archive stuff yet, just enough to see that
you added more code than removed, which is not ideal.