[webkit-reviews] review granted: [Bug 228153] REGRESSION(r280077): [GTK] It caused 155 new test failures : [Attachment 450413] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at gnome.org> has granted Arcady Goldmints-Orlov
<agoldmints at igalia.com>'s request for review:
Bug 228153: REGRESSION(r280077): [GTK] It caused 155 new test failures
https://bugs.webkit.org/show_bug.cgi?id=228153

Attachment 450413: Patch

https://bugs.webkit.org/attachment.cgi?id=450413&action=review




--- Comment #14 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 450413
  --> https://bugs.webkit.org/attachment.cgi?id=450413
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450413&action=review

Nice. LGTM, but please wait a day so Alexander and Carlos Garcia have a chance
to comment before landing.

At least, I cannot think of why it would ever make sense to pass GtkSettings
with the web page rather than the web process. The settings should be the same
for each process, not the same for each page. The current setup seems bogus
compared to what you've done here.

> Tools/WebKitTestRunner/gtk/main.cpp:55
> +    initializeGtkSettings();
>      GRefPtr<GPtrArray> languages = adoptGRef(g_ptr_array_new());

Add a blank line here (it's not part of the spellcheck stuff)