[webkit-reviews] review granted: [Bug 235712] [CSS Container Queries] Basic parsing support for query syntax : [Attachment 450134] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 27 07:57:57 PST 2022


Darin Adler <darin at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 235712: [CSS Container Queries] Basic parsing support for query syntax
https://bugs.webkit.org/show_bug.cgi?id=235712

Attachment 450134: Patch

https://bugs.webkit.org/attachment.cgi?id=450134&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 450134
  --> https://bugs.webkit.org/attachment.cgi?id=450134
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450134&action=review

> Source/WebCore/css/parser/MediaQueryParser.cpp:274
> +	       return !equalIgnoringASCIICase(token.value(), "size");

I suspect this can use the slightly more efficient
equalLettersIgnoringASCIICase


More information about the webkit-reviews mailing list