[webkit-reviews] review granted: [Bug 227621] [Model] Allow disabling interaction : [Attachment 450122] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 27 08:00:50 PST 2022

Darin Adler <darin at apple.com> has granted Antoine Quint <graouts at webkit.org>'s
request for review:
Bug 227621: [Model] Allow disabling interaction

Attachment 450122: Patch


--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 450122
  --> https://bugs.webkit.org/attachment.cgi?id=450122

View in context: https://bugs.webkit.org/attachment.cgi?id=450122&action=review

> Source/WebCore/Modules/model-element/HTMLModelElement.cpp:347
> +void HTMLModelElement::attributeChanged(const QualifiedName& attributeName,
const AtomString& oldValue, const AtomString& newValue,
AttributeModificationReason modificationReason)

Would give these arguments single-word names, "name" and "reason", unless they
seem ambiguous in this context.

More information about the webkit-reviews mailing list