[webkit-reviews] review granted: [Bug 235401] REGRESSION(r288200): [GTK][WPE] Build broken on Ubuntu 18.04 and Debian 10 : [Attachment 449574] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 24 11:37:12 PST 2022


Adrian Perez <aperez at igalia.com> has granted Michael Catanzaro
<mcatanzaro at gnome.org>'s request for review:
Bug 235401: REGRESSION(r288200): [GTK][WPE] Build broken on Ubuntu 18.04 and
Debian 10
https://bugs.webkit.org/show_bug.cgi?id=235401

Attachment 449574: Patch

https://bugs.webkit.org/attachment.cgi?id=449574&action=review




--- Comment #12 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 449574
  --> https://bugs.webkit.org/attachment.cgi?id=449574
Patch

It looks like making the constexpr-crash version of the macros expand
to the corresponding implementation (as done in your patch) should have
been part of the fix for bug #186536 but we missed the change there =)


More information about the webkit-reviews mailing list