[webkit-reviews] review granted: [Bug 235502] Add a WebShare policy quirk for Twitter : [Attachment 449797] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 24 11:38:30 PST 2022


Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 235502: Add a WebShare policy quirk for Twitter
https://bugs.webkit.org/show_bug.cgi?id=235502

Attachment 449797: Patch

https://bugs.webkit.org/attachment.cgi?id=449797&action=review




--- Comment #5 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 449797
  --> https://bugs.webkit.org/attachment.cgi?id=449797
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449797&action=review

r=me

> Source/WebCore/page/Quirks.cpp:89
> +    return topPrivatelyControlledDomain(document.url().host().toString()) ==
"twitter.com";

Why not use RegistrableDomain instead of calling topPrivatelyControlledDomain()
and having to deal with #ifdefs?


More information about the webkit-reviews mailing list