[webkit-reviews] review granted: [Bug 235081] Update hashThreadState() to exclude __opaque_flags. : [Attachment 448875] proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 11 13:43:20 PST 2022

Keith Miller <keith_miller at apple.com> has granted Mark Lam
<mark.lam at apple.com>'s request for review:
Bug 235081: Update hashThreadState() to exclude __opaque_flags.

Attachment 448875: proposed patch.


--- Comment #2 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 448875
  --> https://bugs.webkit.org/attachment.cgi?id=448875
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=448875&action=review

> Source/WTF/wtf/threads/Signals.cpp:175
> +    // Exclude the __opaque_flags field which is reserved for OS use.

Nit: Maybe say that __opaque_flags is at the end of the payload.

More information about the webkit-reviews mailing list