[webkit-reviews] review granted: [Bug 190120] [macOS] [WK2] NSFontPanel UI (font color, text decorations, font shadow) doesn't update on selection change : [Attachment 448162] Rebase on trunk

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 190120: [macOS] [WK2] NSFontPanel UI (font color, text decorations, font
shadow) doesn't update on selection change
https://bugs.webkit.org/show_bug.cgi?id=190120

Attachment 448162: Rebase on trunk

https://bugs.webkit.org/attachment.cgi?id=448162&action=review




--- Comment #7 from Darin Adler <darin at apple.com> ---
Comment on attachment 448162
  --> https://bugs.webkit.org/attachment.cgi?id=448162
Rebase on trunk

View in context: https://bugs.webkit.org/attachment.cgi?id=448162&action=review

> Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:3060
> +	   auto attributesDictionary = attributes.createDictionary();
> +	   if (NSFont *nsFont = [attributesDictionary
objectForKey:NSFontAttributeName]) {

Seems a small waste to build the whole dictionary just to get the font.