[webkit-reviews] review granted: [Bug 234890] ReadableStream::lock should check whether there is an exception when getting ReadableStreamDefaultReader private constructor : [Attachment 448410] Patch

[bugzilla-daemon at webkit.org]

Frédéric Wang (:fredw) <fred.wang at free.fr> has granted	review:
Bug 234890: ReadableStream::lock should check whether there is an exception
when getting ReadableStreamDefaultReader private constructor
https://bugs.webkit.org/show_bug.cgi?id=234890

Attachment 448410: Patch

https://bugs.webkit.org/attachment.cgi?id=448410&action=review




--- Comment #2 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
Comment on attachment 448410
  --> https://bugs.webkit.org/attachment.cgi?id=448410
Patch

LGTM. Do we have a non-regression test for that? IIUC, the current
return-if-exception line is not covered by our tests since otherwise it would
currently crash when JSC::asObject is called?