[webkit-reviews] review granted: [Bug 234880] computed style for transition longhand properties is wrong : [Attachment 448383] Alternative patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Antoine Quint
<graouts at webkit.org>'s request for review:
Bug 234880: computed style for transition longhand properties is wrong
https://bugs.webkit.org/show_bug.cgi?id=234880

Attachment 448383: Alternative patch

https://bugs.webkit.org/attachment.cgi?id=448383&action=review




--- Comment #5 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 448383
  --> https://bugs.webkit.org/attachment.cgi?id=448383
Alternative patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448383&action=review

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:1448
> +    if (property == CSSPropertyAnimationDuration || property ==
CSSPropertyTransitionDuration) {

switch?

> Source/WebCore/platform/animation/Animation.cpp:93
>      , m_timingFunctionSet(o.m_timingFunctionSet)
>      , m_compositeOperationSet(o.m_compositeOperationSet)
>      , m_isNone(o.m_isNone)
> +    , m_delayFilled(o.m_delayFilled)
> +    , m_directionFilled(o.m_directionFilled)
> +    , m_durationFilled(o.m_durationFilled)
> +    , m_fillModeFilled(o.m_fillModeFilled)
> +    , m_iterationCountFilled(o.m_iterationCountFilled)
> +    , m_playStateFilled(o.m_playStateFilled)
> +    , m_propertyFilled(o.m_propertyFilled)
> +    , m_timingFunctionFilled(o.m_timingFunctionFilled)

Does this really need an explicit copy constructor? Doesn't

Animation::Animation(const Animation&) = default;

work?