[webkit-reviews] review granted: [Bug 234884] ServiceWorkerNavigationPreloader::didComplete should make sure to call its bodyCallback : [Attachment 448391] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 234884: ServiceWorkerNavigationPreloader::didComplete should make sure to
call its bodyCallback
https://bugs.webkit.org/show_bug.cgi?id=234884

Attachment 448391: Patch

https://bugs.webkit.org/attachment.cgi?id=448391&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 448391
  --> https://bugs.webkit.org/attachment.cgi?id=448391
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448391&action=review

>
Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerNavigationPreloader.cpp
:207
> +    // After that point, |this| might be destroyed.

which point?
"After calling responseCallback, |this| may be destroyed."