[webkit-reviews] review granted: [Bug 234883] WorkerMessagePortChannelProvider::takeAllMessagesForPort should guarantee execution of the takeMessagePort callback : [Attachment 448388] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 234883: WorkerMessagePortChannelProvider::takeAllMessagesForPort should
guarantee execution of the takeMessagePort callback
https://bugs.webkit.org/show_bug.cgi?id=234883

Attachment 448388: Patch

https://bugs.webkit.org/attachment.cgi?id=448388&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 448388
  --> https://bugs.webkit.org/attachment.cgi?id=448388
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448388&action=review

> Source/WebCore/dom/messageports/WorkerMessagePortChannelProvider.cpp:110
> +    Function<void()> m_completionHandler;

Can this be a CompletionHandler?

> Source/WebCore/dom/messageports/WorkerMessagePortChannelProvider.cpp:119
>	  
MessagePortChannelProvider::singleton().takeAllMessagesForPort(identifier,
[this, workerThread = WTFMove(workerThread),
callbackIdentifier](Vector<MessageWithMessagePorts>&& messages,
Function<void()>&& completionHandler) {

ditto