[webkit-reviews] review granted: [Bug 234771] [LFC][IFC] Incorrect word-spacing gaps between RTL runs : [Attachment 448134] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 234771: [LFC][IFC] Incorrect word-spacing gaps between RTL runs
https://bugs.webkit.org/show_bug.cgi?id=234771

Attachment 448134: Patch

https://bugs.webkit.org/attachment.cgi?id=448134&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 448134
  --> https://bugs.webkit.org/attachment.cgi?id=448134
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448134&action=review

> Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayBox.h:81
> -    bool isText() const { return m_type == Type::Text; }
> +    bool isText() const { return m_type == Type::Text || isWordSeparator();
}
> +    bool isWordSeparator() const { return m_type == Type::WordSeparator; }

Why do we need display boxes for these? What should we do with them during
painting/hit testing?