[webkit-reviews] review granted: [Bug 233441] ScalableImageDecoder should be using SharedBuffer instead of DataSegment : [Attachment 447924] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 1 01:26:44 PST 2022


Darin Adler <darin at apple.com> has granted Jean-Yves Avenard [:jya]
<jean-yves.avenard at apple.com>'s request for review:
Bug 233441: ScalableImageDecoder should be using SharedBuffer instead of
DataSegment
https://bugs.webkit.org/show_bug.cgi?id=233441

Attachment 447924: Patch

https://bugs.webkit.org/attachment.cgi?id=447924&action=review




--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 447924
  --> https://bugs.webkit.org/attachment.cgi?id=447924
Patch

If SharedBuffer is intrinsically immutable, then I think we should be using
RefPtr<SharedBuffer> rather than RefPtr<const SharedBuffer>. Saying const all
the time doesn’t have any meaning, right?


More information about the webkit-reviews mailing list