[webkit-reviews] review granted: [Bug 237168] Change maxTimerNestingLevel from 5 to 10 : [Attachment 453155] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 237168: Change maxTimerNestingLevel from 5 to 10
https://bugs.webkit.org/show_bug.cgi?id=237168

Attachment 453155: Patch

https://bugs.webkit.org/attachment.cgi?id=453155&action=review




--- Comment #2 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 453155
  --> https://bugs.webkit.org/attachment.cgi?id=453155
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453155&action=review

> Source/WebCore/ChangeLog:10
> +
> +	   Recently, we found from Chromium change[1] that changing this from 5
to 10 offers 10% Speedometer2 improvement
> +	   because Speedometer2's setTimeout nesting level is typically 7-8. We
discussed with folks including Chris, Maciej,
> +	   Saam, and Cameron and now we increase this from 5 to 10 to align to
Blink's change to keep these kind of web content fast.

Does the HTML spec say anything here? Perhaps it should? Probably at least
worth filing an issue.