[webkit-reviews] review granted: [Bug 237262] Adopt the modern Hasher more widely : [Attachment 453392] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 237262: Adopt the modern Hasher more widely
https://bugs.webkit.org/show_bug.cgi?id=237262

Attachment 453392: Patch

https://bugs.webkit.org/attachment.cgi?id=453392&action=review




--- Comment #5 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 453392
  --> https://bugs.webkit.org/attachment.cgi?id=453392
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453392&action=review

Love seeing this.

> Source/WebKit/Platform/IPC/StringReference.cpp:62
> +    return computeHash(a);

This parameter names could be better. string? reference? stringReference?