[webkit-reviews] review denied: [Bug 211131] [WPE][GTK] Paths should be canonicalized before calling bwrap : [Attachment 452983] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at gnome.org> has denied apteryx
<maxim.cournoyer at gmail.com>'s request for review:
Bug 211131: [WPE][GTK] Paths should be canonicalized before calling bwrap
https://bugs.webkit.org/show_bug.cgi?id=211131

Attachment 452983: Patch

https://bugs.webkit.org/attachment.cgi?id=452983&action=review




--- Comment #4 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 452983
  --> https://bugs.webkit.org/attachment.cgi?id=452983
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452983&action=review

> Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp:330
> +    if (path == realPath) {

Seems this was supposed to be !=, which indicates that another round of testing
is warranted here. ;)