[webkit-reviews] review granted: [Bug 237086] webrtc/video-replace-muted-track.html is unnecessary long to run : [Attachment 452980] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Feb 23 10:28:58 PST 2022
Peng Liu <peng.liu6 at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 237086: webrtc/video-replace-muted-track.html is unnecessary long to run
https://bugs.webkit.org/show_bug.cgi?id=237086
Attachment 452980: Patch
https://bugs.webkit.org/attachment.cgi?id=452980&action=review
--- Comment #2 from Peng Liu <peng.liu6 at apple.com> ---
Comment on attachment 452980
--> https://bugs.webkit.org/attachment.cgi?id=452980
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=452980&action=review
> LayoutTests/webrtc/video-replace-muted-track.html:47
> + return checkVideoBlack(true, canvas, video, "Check we do not receive
any black frame", 360).then(assert_unreached, () => { });
To be honest, I was confused by the change at the beginning. Because you change
40 -> 360 here, which is not consistent with the change log. But I got your
point after reading the source code. :-)
More information about the webkit-reviews
mailing list