[webkit-reviews] review granted: [Bug 236910] [WebGPU] Tracer bullet part 10: Implement setLabel() and Metal accessors : [Attachment 452678] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 236910: [WebGPU] Tracer bullet part 10: Implement setLabel() and Metal
accessors
https://bugs.webkit.org/show_bug.cgi?id=236910

Attachment 452678: Patch

https://bugs.webkit.org/attachment.cgi?id=452678&action=review




--- Comment #2 from Dean Jackson <dino at apple.com> ---
Comment on attachment 452678
  --> https://bugs.webkit.org/attachment.cgi?id=452678
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452678&action=review

> Source/WebGPU/WebGPU/RenderPassEncoder.mm:178
> +    m_renderCommandEncoder.label = [NSString stringWithCString:label
encoding:NSUTF8StringEncoding];

Do you ever want to ASSERT that m_renderCommandEncoder etc exist?