[webkit-reviews] review granted: [Bug 236903] [WebGPU] Tracer bullet part 9: Basic implementation of bindings : [Attachment 452675] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 236903: [WebGPU] Tracer bullet part 9: Basic implementation of bindings
https://bugs.webkit.org/show_bug.cgi?id=236903

Attachment 452675: Patch

https://bugs.webkit.org/attachment.cgi?id=452675&action=review




--- Comment #4 from Dean Jackson <dino at apple.com> ---
Comment on attachment 452675
  --> https://bugs.webkit.org/attachment.cgi?id=452675
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452675&action=review

> Source/WebGPU/WebGPU/BindGroup.h:48
> +    id <MTLBuffer> vertexArgumentBuffer() const { return
m_vertexArgumentBuffer; }
> +    id <MTLBuffer> fragmentArgumentBuffer() const { return
m_fragmentArgumentBuffer; }
> +    id <MTLBuffer> computeArgumentBuffer() const { return
m_computeArgumentBuffer; }

id<MTLBuffer> no space. Here and elsewhere.