[webkit-reviews] review granted: [Bug 236662] [libpas] Use segmented vector for TLC layout list : [Attachment 452282] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 236662: [libpas] Use segmented vector for TLC layout list
https://bugs.webkit.org/show_bug.cgi?id=236662

Attachment 452282: Patch

https://bugs.webkit.org/attachment.cgi?id=452282&action=review




--- Comment #11 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 452282
  --> https://bugs.webkit.org/attachment.cgi?id=452282
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452282&action=review

Nice! r=me

> Source/bmalloc/ChangeLog:9
> +	   linked-list of that to accelerate iteration performance. It does not
affect on speed,

What do you mean by "It does not affect on speed"? Isn't the idea to make this
faster, as you say below

> Source/bmalloc/ChangeLog:13
> +	   well without taking a lock in most times which is blocked by
scavenger, making scavenger
> +	   faster is good for energy efficiency.

Maybe instead of speed, you can say "throughput of non scavenger threads"?
Since this is speeding up the scavenger thread, but speeding up the scavenger
thread doesn't speed up allocator threads.