[webkit-reviews] review requested: [Bug 236683] [XCBuild] Use native build phases to copy PAL's headers : [Attachment 452285] Native PAL Headers via build rules + a legacy-only script phase, v2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Feb 16 18:47:45 PST 2022
Elliott Williams <emw at apple.com> has asked for review:
Bug 236683: [XCBuild] Use native build phases to copy PAL's headers
https://bugs.webkit.org/show_bug.cgi?id=236683
Attachment 452285: Native PAL Headers via build rules + a legacy-only script
phase, v2
https://bugs.webkit.org/attachment.cgi?id=452285&action=review
--- Comment #7 from Elliott Williams <emw at apple.com> ---
Created attachment 452285
--> https://bugs.webkit.org/attachment.cgi?id=452285&action=review
Native PAL Headers via build rules + a legacy-only script phase, v2
Per offline discussion, I think we should move forward with an approach that
deletes the rsync script entirely, and uses a legacy-only script phase to
un-flatten the headers. This has the benefit of enforcing that, on the legacy
build system, all headers must be part of the target's Headers phase.
More information about the webkit-reviews
mailing list