[webkit-reviews] review granted: [Bug 236479] Enable grammar checking on Mac Catalyst. : [Attachment 451632] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 236479: Enable grammar checking on Mac Catalyst.
https://bugs.webkit.org/show_bug.cgi?id=236479

Attachment 451632: Patch

https://bugs.webkit.org/attachment.cgi?id=451632&action=review




--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 451632
  --> https://bugs.webkit.org/attachment.cgi?id=451632
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451632&action=review

r=mews, nice! :)

> Source/WebCore/platform/graphics/cocoa/GraphicsContextCocoa.mm:66
> +

Style: extra whitespace

> Source/WebKit/UIProcess/ios/TextCheckerIOS.mm:254
> +		       ASSERT(detailRangeAsNSValue);
> +		       NSRange detailNSRange = [detailRangeAsNSValue
rangeValue];

Style: I'd maybe sprinkle some newlines in here so it's a bit less
"wall-of-text"-y ��

> Source/WebKit/UIProcess/ios/TextCheckerIOS.mm:261
> +			   detail.guesses.append(String(guess));

NIT: Is the `String` necessary?