[webkit-reviews] review granted: [Bug 236409] null ptr deref in WebCore::HTMLModelElement::enterFullscreen() : [Attachment 451715] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 11 12:52:33 PST 2022


Antoine Quint <graouts at webkit.org> has granted Gabriel Nava Marino
<gnavamarino at apple.com>'s request for review:
Bug 236409: null ptr deref in WebCore::HTMLModelElement::enterFullscreen()
https://bugs.webkit.org/show_bug.cgi?id=236409

Attachment 451715: Patch

https://bugs.webkit.org/attachment.cgi?id=451715&action=review




--- Comment #7 from Antoine Quint <graouts at webkit.org> ---
Comment on attachment 451715
  --> https://bugs.webkit.org/attachment.cgi?id=451715
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451715&action=review

> LayoutTests/model-element/model-element-enter-fullscreen-crash.html:3
> +  internals.settings.setModelElementEnabled(true);

You don't need that line, it's already enabled in WKTR.


More information about the webkit-reviews mailing list