[webkit-reviews] review granted: [Bug 236167] [Cocoa] Always sync ResourceRequest isAppInitiated request with NSURLRequest attribution value : [Attachment 450962] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Brent Fulgham <bfulgham at webkit.org>'s
request for review:
Bug 236167: [Cocoa] Always sync ResourceRequest isAppInitiated request with
NSURLRequest attribution value
https://bugs.webkit.org/show_bug.cgi?id=236167

Attachment 450962: Patch

https://bugs.webkit.org/attachment.cgi?id=450962&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 450962
  --> https://bugs.webkit.org/attachment.cgi?id=450962
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450962&action=review

Can we make a regression test to show what this fixes?

> Source/WebCore/platform/network/cocoa/ResourceRequestCocoa.mm:45
> +    : ResourceRequestBase()

Is this explicit initialization of the base class required? I suggest we try
removing this; I believe it will still compile and generate the same code
without it.

> Source/WebCore/platform/network/cocoa/ResourceRequestCocoa.mm:301
> +    nsRequest.get().attribution = request.attribution;

Why use the setAttribution: syntax above, but the assignment syntax here? I
would like ie better if it was consistent. I suggest we use the assignment
syntax in all three places.