[webkit-reviews] review granted: [Bug 234944] WTF::HashAndUTF8CharactersTranslator::translate() falls through ASSERT_NOT_REACHED() : [Attachment 451048] Patch v1

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 234944: WTF::HashAndUTF8CharactersTranslator::translate() falls through
ASSERT_NOT_REACHED()
https://bugs.webkit.org/show_bug.cgi?id=234944

Attachment 451048: Patch v1

https://bugs.webkit.org/attachment.cgi?id=451048&action=review




--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 451048
  --> https://bugs.webkit.org/attachment.cgi?id=451048
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=451048&action=review

> Source/WTF/wtf/text/AtomStringImpl.cpp:201
> +	       isAllASCII = true; // Force copy of original buffer.

This doesn't make a lot of sense; it will incorrectly convert UTF-8 sequences
into Latin-1 characters. I think CRASH() or abort() or whatever would be
better. However, it really doesn’t matter because this code won’t ever be
reached.