[webkit-reviews] review granted: [Bug 235855] Forward messages from NetworkProcess to webpushd : [Attachment 450354] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 1 16:33:25 PST 2022


Brent Fulgham <bfulgham at webkit.org> has granted Ben Nham <nham at apple.com>'s
request for review:
Bug 235855: Forward messages from NetworkProcess to webpushd
https://bugs.webkit.org/show_bug.cgi?id=235855

Attachment 450354: Patch

https://bugs.webkit.org/attachment.cgi?id=450354&action=review




--- Comment #6 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 450354
  --> https://bugs.webkit.org/attachment.cgi?id=450354
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450354&action=review

> Source/WebKit/webpushd/WebPushDaemon.mm:481
> +    UNUSED_PARAM(applicationServerKey);

Should we have any kind of MESSAGE_CHECK macros in here for connection, etc.?
Maybe that comes later, once this is fleshed out more?


More information about the webkit-reviews mailing list