[webkit-reviews] review granted: [Bug 235939] [GPU Process] Remove DisplayList::Replayer::Delegate and DisplayList::RecorderImpl::Delegate : [Attachment 450507] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 1 10:55:02 PST 2022
Wenson Hsieh <wenson_hsieh at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 235939: [GPU Process] Remove DisplayList::Replayer::Delegate and
DisplayList::RecorderImpl::Delegate
https://bugs.webkit.org/show_bug.cgi?id=235939
Attachment 450507: Patch
https://bugs.webkit.org/attachment.cgi?id=450507&action=review
--- Comment #5 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 450507
--> https://bugs.webkit.org/attachment.cgi?id=450507
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=450507&action=review
> Source/WebCore/platform/graphics/displaylists/DisplayListReplayer.cpp:94
> + return *imageIdentifier;
Nit - let's keep these return types on line 94 and 97 consistent (maybe by
getting the value inside the optional in both cases).
More information about the webkit-reviews
mailing list