[webkit-reviews] review granted: [Bug 235896] [CSS Container Queries] Ensure query containers have valid layout before resolving the subtree : [Attachment 450518] Patch

[bugzilla-daemon at webkit.org]

zalan <zalan at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s request
for review:
Bug 235896: [CSS Container Queries] Ensure query containers have valid layout
before resolving the subtree
https://bugs.webkit.org/show_bug.cgi?id=235896

Attachment 450518: Patch

https://bugs.webkit.org/attachment.cgi?id=450518&action=review




--- Comment #3 from zalan <zalan at apple.com> ---
Comment on attachment 450518
  --> https://bugs.webkit.org/attachment.cgi?id=450518
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450518&action=review

> Source/WebCore/ChangeLog:24
> +	   Don't run post-layout tasks when resolving query containers.

yeah, I wish there was a disposable layout type of thing where we could just
run layout on the tree, produce geometry and let the rest of the update flow
take care of the "final" layout including paint invalidation etc. Running the
post layout tasks (even on a subsequent runloop) may also produce some
unexpected results.

> Source/WebCore/dom/Document.cpp:2063
> +	       if (frameView.layoutContext().isLayoutPending() ||
renderView()->needsLayout())

I'd just check FrameViewLayoutContext::needsLayout() (in addition to ^^, it
also covers things like subtree layout, which may get triggered by containment)