[webkit-reviews] review granted: [Bug 239748] Adjust some image transcoding behaviors related to "Copy Cropped Image" : [Attachment 458327] Patch

[bugzilla-daemon at webkit.org]

Kate Cheney <katherine_cheney at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 239748: Adjust some image transcoding behaviors related to "Copy Cropped
Image"
https://bugs.webkit.org/show_bug.cgi?id=239748

Attachment 458327: Patch

https://bugs.webkit.org/attachment.cgi?id=458327&action=review




--- Comment #2 from Kate Cheney <katherine_cheney at apple.com> ---
Comment on attachment 458327
  --> https://bugs.webkit.org/attachment.cgi?id=458327
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458327&action=review

looks good! A couple Qs

> Source/WebKit/Platform/cocoa/CocoaImage.mm:-56
> -    if (CFStringGetLength(preferredMIMEType)) {

should we keep this check or add an assert that the CFStringRef isn't empty for
future callers?

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:11034
> +	   auto [data, type] = WebKit::imageDataForCroppedImageResult(result,
(__bridge CFStringRef)sourceMIMEType.get());

Do we no longer need to worry about if the result is nil in this case?