[webkit-reviews] review granted: [Bug 239760] PlatformDisplay::PlatformDisplay(GdkDisplay* display) does not set m_eglDisplay to EGL_NO_DISPLAY : [Attachment 458354] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 26 08:30:58 PDT 2022


Michael Catanzaro <mcatanzaro at gnome.org> has granted Xi Ruoyao
<xry111 at mengyan1223.wang>'s request for review:
Bug 239760: PlatformDisplay::PlatformDisplay(GdkDisplay* display) does not set
m_eglDisplay to EGL_NO_DISPLAY
https://bugs.webkit.org/show_bug.cgi?id=239760

Attachment 458354: Patch

https://bugs.webkit.org/attachment.cgi?id=458354&action=review




--- Comment #2 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 458354
  --> https://bugs.webkit.org/attachment.cgi?id=458354
Patch

Oops.

This change looks safe and good. But could you please use the initializer list,
as in the constructor above?


More information about the webkit-reviews mailing list