[webkit-reviews] review granted: [Bug 239460] Inline Element::shadowRoot() : [Attachment 457854] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 239460: Inline Element::shadowRoot()
https://bugs.webkit.org/show_bug.cgi?id=239460

Attachment 457854: Patch

https://bugs.webkit.org/attachment.cgi?id=457854&action=review




--- Comment #11 from Darin Adler <darin at apple.com> ---
Comment on attachment 457854
  --> https://bugs.webkit.org/attachment.cgi?id=457854
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457854&action=review

> Source/WebCore/dom/Element.h:318
> +    ShadowRoot* shadowRoot() const;

If we add the inline keyword to the declaration of shadowRoot (like replace
WEBCORE_EXPORT with inline) then, I seem to recall, we get compiler errors
rather than linker errors when we call it without remembering to include
ElementRareData.h. So I suggest including that keyword. We should use that
technique more! I think Jer Noble is the one who pointed this out to me.

> Source/WebCore/editing/cocoa/DataDetection.mm:694
> +std::optional<std::pair<Ref<HTMLElement>, IntRect>>
DataDetection::findDataDetectionResultElementInImageOverlay(const FloatPoint&
location, const HTMLElement& imageOverlayHost)

This seems like a really good change, but not mentioned in change log.