[webkit-reviews] review granted: [Bug 239336] Update in-field icons for credential fields : [Attachment 457816] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 19 09:43:13 PDT 2022 

Wenson Hsieh <wenson_hsieh at apple.com> has granted Ricky Mondello
<rmondello at apple.com>'s request for review:
Bug 239336: Update in-field icons for credential fields
https://bugs.webkit.org/show_bug.cgi?id=239336

Attachment 457816: Patch

https://bugs.webkit.org/attachment.cgi?id=457816&action=review




--- Comment #10 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 457816
  --> https://bugs.webkit.org/attachment.cgi?id=457816
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457816&action=review

> Source/WebCore/css/html.css:617
> +background-image: url("data:image/svg+xml,%3Csvg viewBox='0 0 26 26'
xmlns='http://www.w3.org/2000/svg'
xmlns:xlink='http://www.w3.org/1999/xlink'%3E%3CclipPath id='a'%3E%3Cpath
clip-rule='evenodd' d='m8.692 1h8.617c2.675 0 3.644.278 4.622.801s1.745 1.29
2.268 2.268.801 1.948.801 4.622v8.617c0 2.675-.278 3.644-.801 4.622s-1.29
1.745-2.268 2.268-1.948.801-4.622.801h-8.617c-2.675
0-3.644-.278-4.622-.801s-1.745-1.29-2.268-2.268-.801-1.948-.801-4.622v-8.616c0-
2.675.278-3.644.801-4.622s1.29-1.745 2.268-2.268 1.948-.801
4.622-.801z'/%3E%3C/clipPath%3E%3CclipPath id='b'%3E%3Cpath d='m9.838
8.318c-.308
0-.57-.108-.787-.325s-.325-.478-.325-.785.108-.57.323-.787.478-.325.789-.325c.3
03 0 .564.109.782.327s.327.48.327.785c0
.306-.109.568-.327.785s-.479.325-.782.325zm0-3.84c-.59
0-1.139.108-1.648.324s-.956.517-1.341.903-.686.833-.904 1.341-.326 1.055-.326
1.641c0 .571.106 1.112.317 1.622s.51.961.896 1.352.841.698 1.366.918v6.082c0
.101.018.196.054.287s.092.173.167.247l1.122
1.077c.083.078.19.12.32.126s.244-.039.343-.136l1.998-1.998c.104-.105.155-.227.1
53-.365s-.054-.26-.157-.365l-1.094-1.083
1.555-1.553c.101-.102.151-.223.149-.361-.001-.138-.054-.26-.158-.365l-1.488-1.4
96c.929-.411 1.644-.964 2.142-1.66.499-.696.748-1.472.748-2.329
0-.581-.109-1.126-.327-1.635s-.52-.956-.905-1.341-.833-.687-1.343-.905-1.057-.3
27-1.639-.327z'/%3E%3C/clipPath%3E%3CclipPath id='c'%3E%3Cpath d='m19.091
15.574c.108-.002.207-.023.296-.064.09-.041.179-.105.268-.193l2.462-2.522c.126-.
124.189-.278.189-.46
0-.124-.03-.237-.091-.34s-.141-.185-.242-.245c-.101-.061-.212-.091-.334-.091-.1
87 0-.352.073-.495.22l-2.165
2.249h.232l-2.175-2.249c-.145-.147-.311-.22-.497-.22-.122
0-.234.03-.334.091-.101.061-.182.142-.242.245-.061.103-.091.216-.091.34 0
.09.015.173.046.248s.078.146.14.212l2.467
2.521c.171.171.36.256.565.256z'/%3E%3C/clipPath%3E%3Cg
clip-path='url(%23a)'%3E%3Cpath d='m0 0h26v26h-26z' fill='%23e5e5e5'
opacity='.64'/%3E%3C/g%3E%3Cg clip-path='url(%23b)'%3E%3Cpath d='m4.619
3.478h10.434v17.927h-10.434z' opacity='.78'/%3E%3C/g%3E%3Cg
clip-path='url(%23c)'%3E%3Cpath d='m14.872 10.66h8.435v5.914h-8.435z'
opacity='.75'/%3E%3C/g%3E%3C/svg%3E");

Nit - indentation seems missing before `background-image`.

> Source/WebCore/css/html.css:638
> +background-image: url("data:image/svg+xml,%3Csvg viewBox='0 0 26 26'
xmlns='http://www.w3.org/2000/svg'
xmlns:xlink='http://www.w3.org/1999/xlink'%3E%3CclipPath id='a'%3E%3Cpath
clip-rule='evenodd' d='m8.692 1h8.617c2.675 0 3.644.278 4.622.801s1.745 1.29
2.268 2.268.801 1.948.801 4.622v8.617c0 2.675-.278 3.644-.801 4.622s-1.29
1.745-2.268 2.268-1.948.801-4.622.801h-8.617c-2.675
0-3.644-.278-4.622-.801s-1.745-1.29-2.268-2.268-.801-1.948-.801-4.622v-8.616c0-
2.675.278-3.644.801-4.622s1.29-1.745 2.268-2.268 1.948-.801
4.622-.801z'/%3E%3C/clipPath%3E%3CclipPath id='b'%3E%3Cpath clip-rule='evenodd'
d='m8.692 1h8.617c2.675 0 3.644.278 4.622.801s1.745 1.29 2.268 2.268.801
1.948.801 4.622v8.617c0 2.675-.278 3.644-.801 4.622s-1.29 1.745-2.268
2.268-1.948.801-4.622.801h-8.617c-2.675
0-3.644-.278-4.622-.801s-1.745-1.29-2.268-2.268-.801-1.948-.801-4.622v-8.616c0-
2.675.278-3.644.801-4.622s1.29-1.745 2.268-2.268 1.948-.801
4.622-.801z'/%3E%3C/clipPath%3E%3CclipPath id='c'%3E%3Cpath d='m9.838
8.318c-.308
0-.57-.108-.787-.325s-.325-.478-.325-.785.108-.57.323-.787.478-.325.789-.325c.3
03 0 .564.109.782.327s.327.48.327.785c0
.306-.109.568-.327.785s-.479.325-.782.325zm0-3.84c-.59
0-1.139.108-1.648.324s-.956.517-1.341.903-.686.833-.904 1.341-.326 1.055-.326
1.641c0 .571.106 1.112.317 1.622s.51.961.896 1.352.841.698 1.366.918v6.082c0
.101.018.196.054.287s.092.173.167.247l1.122
1.077c.083.078.19.12.32.126s.244-.039.343-.136l1.998-1.998c.104-.105.155-.227.1
53-.365s-.054-.26-.157-.365l-1.094-1.083
1.555-1.553c.101-.102.151-.223.149-.361-.001-.138-.054-.26-.158-.365l-1.488-1.4
96c.929-.411 1.644-.964 2.142-1.66.499-.696.748-1.472.748-2.329
0-.581-.109-1.126-.327-1.635s-.52-.956-.905-1.341-.833-.687-1.343-.905-1.057-.3
27-1.639-.327z'/%3E%3C/clipPath%3E%3CclipPath id='d'%3E%3Cpath d='m19.091
15.574c.108-.002.207-.023.296-.064.09-.041.179-.105.268-.193l2.462-2.522c.126-.
124.189-.278.189-.46
0-.124-.03-.237-.091-.34s-.141-.185-.242-.245c-.101-.061-.212-.091-.334-.091-.1
87 0-.352.073-.495.22l-2.165
2.249h.232l-2.175-2.249c-.145-.147-.311-.22-.497-.22-.122
0-.234.03-.334.091-.101.061-.182.142-.242.245-.061.103-.091.216-.091.34 0
.09.015.173.046.248s.078.146.14.212l2.467
2.521c.171.171.36.256.565.256z'/%3E%3C/clipPath%3E%3Cg
clip-path='url(%23a)'%3E%3Cpath d='m0 0h26v26h-26z' fill='%23e5e5e5'
opacity='.7'/%3E%3C/g%3E%3Cg clip-path='url(%23b)'%3E%3Cpath d='m8.692
1h8.617c2.675 0 3.644.278 4.622.801s1.745 1.29 2.268 2.268.801 1.948.801
4.622v8.617c0 2.675-.278 3.644-.801 4.622s-1.29 1.745-2.268
2.268-1.948.801-4.622.801h-8.617c-2.675
0-3.644-.278-4.622-.801s-1.745-1.29-2.268-2.268-.801-1.948-.801-4.622v-8.616c0-
2.675.278-3.644.801-4.622s1.29-1.745 2.268-2.268 1.948-.801 4.622-.801z'
fill='none' opacity='.15' stroke='%23e6e6e6' stroke-miterlimit='5'
stroke-width='2'/%3E%3C/g%3E%3Cg clip-path='url(%23c)'%3E%3Cpath d='m4.619
3.478h10.434v17.927h-10.434z'/%3E%3C/g%3E%3Cg clip-path='url(%23d)'%3E%3Cpath
d='m14.872 10.66h8.435v5.914h-8.435z'/%3E%3C/g%3E%3C/svg%3E");

(Ditto)

> Source/WebCore/css/html.css:646
> +background-image: url("data:image/svg+xml,%3Csvg viewBox='0 0 26 26'
xmlns='http://www.w3.org/2000/svg'
xmlns:xlink='http://www.w3.org/1999/xlink'%3E%3CclipPath id='a'%3E%3Cpath
clip-rule='evenodd' d='m8.692 1h8.617c2.675 0 3.644.278 4.622.801s1.745 1.29
2.268 2.268.801 1.948.801 4.622v8.617c0 2.675-.278 3.644-.801 4.622s-1.29
1.745-2.268 2.268-1.948.801-4.622.801h-8.617c-2.675
0-3.644-.278-4.622-.801s-1.745-1.29-2.268-2.268-.801-1.948-.801-4.622v-8.616c0-
2.675.278-3.644.801-4.622s1.29-1.745 2.268-2.268 1.948-.801
4.622-.801z'/%3E%3C/clipPath%3E%3CclipPath id='b'%3E%3Cpath clip-rule='evenodd'
d='m8.692 1h8.617c2.675 0 3.644.278 4.622.801s1.745 1.29 2.268 2.268.801
1.948.801 4.622v8.617c0 2.675-.278 3.644-.801 4.622s-1.29 1.745-2.268
2.268-1.948.801-4.622.801h-8.617c-2.675
0-3.644-.278-4.622-.801s-1.745-1.29-2.268-2.268-.801-1.948-.801-4.622v-8.616c0-
2.675.278-3.644.801-4.622s1.29-1.745 2.268-2.268 1.948-.801
4.622-.801z'/%3E%3C/clipPath%3E%3CclipPath id='c'%3E%3Cpath d='m9.838
8.318c-.308
0-.57-.108-.787-.325s-.325-.478-.325-.785.108-.57.323-.787.478-.325.789-.325c.3
03 0 .564.109.782.327s.327.48.327.785c0
.306-.109.568-.327.785s-.479.325-.782.325zm0-3.84c-.59
0-1.139.108-1.648.324s-.956.517-1.341.903-.686.833-.904 1.341-.326 1.055-.326
1.641c0 .571.106 1.112.317 1.622s.51.961.896 1.352.841.698 1.366.918v6.082c0
.101.018.196.054.287s.092.173.167.247l1.122
1.077c.083.078.19.12.32.126s.244-.039.343-.136l1.998-1.998c.104-.105.155-.227.1
53-.365s-.054-.26-.157-.365l-1.094-1.083
1.555-1.553c.101-.102.151-.223.149-.361-.001-.138-.054-.26-.158-.365l-1.488-1.4
96c.929-.411 1.644-.964 2.142-1.66.499-.696.748-1.472.748-2.329
0-.581-.109-1.126-.327-1.635s-.52-.956-.905-1.341-.833-.687-1.343-.905-1.057-.3
27-1.639-.327z'/%3E%3C/clipPath%3E%3CclipPath id='d'%3E%3Cpath d='m19.091
15.574c.108-.002.207-.023.296-.064.09-.041.179-.105.268-.193l2.462-2.522c.126-.
124.189-.278.189-.46
0-.124-.03-.237-.091-.34s-.141-.185-.242-.245c-.101-.061-.212-.091-.334-.091-.1
87 0-.352.073-.495.22l-2.165
2.249h.232l-2.175-2.249c-.145-.147-.311-.22-.497-.22-.122
0-.234.03-.334.091-.101.061-.182.142-.242.245-.061.103-.091.216-.091.34 0
.09.015.173.046.248s.078.146.14.212l2.467
2.521c.171.171.36.256.565.256z'/%3E%3C/clipPath%3E%3Cg
clip-path='url(%23a)'%3E%3Cpath d='m0 0h26v26h-26z' fill='%23b2b2b2'
opacity='.6'/%3E%3C/g%3E%3Cg clip-path='url(%23b)'%3E%3Cpath d='m8.692
1h8.617c2.675 0 3.644.278 4.622.801s1.745 1.29 2.268 2.268.801 1.948.801
4.622v8.617c0 2.675-.278 3.644-.801 4.622s-1.29 1.745-2.268
2.268-1.948.801-4.622.801h-8.617c-2.675
0-3.644-.278-4.622-.801s-1.745-1.29-2.268-2.268-.801-1.948-.801-4.622v-8.616c0-
2.675.278-3.644.801-4.622s1.29-1.745 2.268-2.268 1.948-.801 4.622-.801z'
fill='none' opacity='.15' stroke='%23b2b2b2' stroke-miterlimit='5'
stroke-width='2'/%3E%3C/g%3E%3Cg clip-path='url(%23c)'%3E%3Cpath d='m4.619
3.478h10.434v17.927h-10.434z'/%3E%3C/g%3E%3Cg clip-path='url(%23d)'%3E%3Cpath
d='m14.872 10.66h8.435v5.914h-8.435z'/%3E%3C/g%3E%3C/svg%3E");

(Ditto)

More information about the webkit-reviews mailing list