[webkit-reviews] review requested: [Bug 238664] Reject Clients.openWindow and Client.navigate promises in some failure cases : [Attachment 457034] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has asked  for review:
Bug 238664: Reject Clients.openWindow and Client.navigate promises in some
failure cases
https://bugs.webkit.org/show_bug.cgi?id=238664

Attachment 457034: Patch

https://bugs.webkit.org/attachment.cgi?id=457034&action=review




--- Comment #6 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 457034
  --> https://bugs.webkit.org/attachment.cgi?id=457034
Patch

Marking as r?
This patch makes it more consistent in navigate algorithm when UIProcess stops
the load differently (in case of 'view-source//' and in case of 'file:///'). We
align with Chrome behavior here.
It also rejects in case the service worker openWindow delegate is not
implemented, which I think mirrors what Chrome is doing.
This area still needs some interop and spec work since Firefox for instance is
not rejecting on 'file:///'but does on 'view-source://'.