[webkit-reviews] review granted: [Bug 239050] [WebGPU] Implement correct ownership for WGPUQueues : [Attachment 457205] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 11 01:15:35 PDT 2022


Kimmo Kinnunen <kkinnunen at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 239050: [WebGPU] Implement correct ownership for WGPUQueues
https://bugs.webkit.org/show_bug.cgi?id=239050

Attachment 457205: Patch

https://bugs.webkit.org/attachment.cgi?id=457205&action=review




--- Comment #2 from Kimmo Kinnunen <kkinnunen at apple.com> ---
Comment on attachment 457205
  --> https://bugs.webkit.org/attachment.cgi?id=457205
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457205&action=review

> Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj:-1964
> -				DD20DE6027BC90D80093D175 /* Gunzip.h in Headers
*/,

I wonder what this reordering is about..

> Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUDeviceHolderImpl.h:37
> +class ConvertToBackingContext;

redundant forward declare?


More information about the webkit-reviews mailing list