[webkit-reviews] review granted: [Bug 230284] Addition of CSSTransformValue, CSSTransformComponent & subclasses : [Attachment 438424] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Qiaosong Zhou
<qiaosong_zhou at apple.com>'s request for review:
Bug 230284: Addition of CSSTransformValue, CSSTransformComponent & subclasses
https://bugs.webkit.org/show_bug.cgi?id=230284

Attachment 438424: Patch

https://bugs.webkit.org/attachment.cgi?id=438424&action=review




--- Comment #10 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 438424
  --> https://bugs.webkit.org/attachment.cgi?id=438424
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438424&action=review

> Source/WebCore/bindings/js/JSCSSTransformComponentCustom.cpp:2
> + * Copyright (C) 2018 Apple Inc. All rights reserved.

2021

> Source/WebCore/bindings/js/JSCSSTransformComponentCustom.cpp:46
> +    if (is<CSSMatrixComponent>(value.get()))

Can this be a switch statement instead?

> Source/WebCore/css/typedom/transform/CSSTransformComponent.h:61
> +

nit: extra space