[webkit-reviews] review granted: [Bug 230061] Unbreak GCC_OFFLINEASM_SOURCE_MAP when LTO is in use : [Attachment 438488] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 17 12:55:44 PDT 2021

Michael Catanzaro <mcatanzaro at gnome.org> has granted Angelos Oikonomopoulos
<angelos at igalia.com>'s request for review:
Bug 230061: Unbreak GCC_OFFLINEASM_SOURCE_MAP when LTO is in use

Attachment 438488: Patch


--- Comment #4 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 438488
  --> https://bugs.webkit.org/attachment.cgi?id=438488

View in context: https://bugs.webkit.org/attachment.cgi?id=438488&action=review

Tested this. It works. Thanks Angelos!

> Source/JavaScriptCore/CMakeLists.txt:1472
> +	   COMPILE_OPTIONS "-fno-lto")

OK, I was going to whine that you need to check if the option is supported, but
this is within a CMAKE_COMPILER_IS_GNUCXX guard so no need.

More information about the webkit-reviews mailing list