[webkit-reviews] review granted: [Bug 229023] Support patterns with a wide gamut source : [Attachment 438010] Patch for review, without dependencies (which will fail EWS)

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Cameron McCormack (:heycam)
<heycam at apple.com>'s request for review:
Bug 229023: Support patterns with a wide gamut source
https://bugs.webkit.org/show_bug.cgi?id=229023

Attachment 438010: Patch for review, without dependencies (which will fail EWS)

https://bugs.webkit.org/attachment.cgi?id=438010&action=review




--- Comment #6 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 438010
  --> https://bugs.webkit.org/attachment.cgi?id=438010
Patch for review, without dependencies (which will fail EWS)

View in context: https://bugs.webkit.org/attachment.cgi?id=438010&action=review

> Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:469
> +	   auto bitmap = ShareableBitmap::createShareable(resultSize, {
imageBuffer->colorSpace() });

A great follow up would be to make the ShareableBitmap's configuration
colorspace not optional, requiring each callsite to explicitly specify it. This
has been a useful pattern in finding places where sRGB is implicit that can
otherwise be hard to find.