[webkit-reviews] review granted: [Bug 229021] Support drawImage with a wide gamut image painting into a display-p3 canvas : [Attachment 438006] Patch without dependencies (and so will fail EWS)

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Cameron McCormack (:heycam)
<heycam at apple.com>'s request for review:
Bug 229021: Support drawImage with a wide gamut image painting into a
display-p3 canvas
https://bugs.webkit.org/show_bug.cgi?id=229021

Attachment 438006: Patch without dependencies (and so will fail EWS)

https://bugs.webkit.org/attachment.cgi?id=438006&action=review




--- Comment #19 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 438006
  --> https://bugs.webkit.org/attachment.cgi?id=438006
Patch without dependencies (and so will fail EWS)

View in context: https://bugs.webkit.org/attachment.cgi?id=438006&action=review

> Source/WebKit/Shared/cg/ShareableBitmapCG.cpp:46
> +    CGColorSpaceRef colorSpace =
configuration.colorSpace->platformColorSpace();

I was poking around after we discussed this, and it turns out there is some
interesting SPI in CoreGraphics related to this that we might want to explore:

CGBitmapContextCreateForFlatteningImage()

I think we should ask the CoreGraphics folks if it would make sense for us to
use it.