[webkit-reviews] review granted: [Bug 229844] FontFaceSet.check() needs to react to style changes : [Attachment 437234] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 229844: FontFaceSet.check() needs to react to style changes
https://bugs.webkit.org/show_bug.cgi?id=229844

Attachment 437234: Patch

https://bugs.webkit.org/attachment.cgi?id=437234&action=review




--- Comment #4 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 437234
  --> https://bugs.webkit.org/attachment.cgi?id=437234
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437234&action=review

Should we / can we have a font resource that never get's cached (e.g. sets the
right headers) to avoid the need to invalidate?

> Source/WebCore/css/FontFaceSet.cpp:186
> +    auto protect = m_backing;

Like the other patch, I would change this to:

Ref protect = m_backing;

(assuming that compiles).