[webkit-reviews] review granted: [Bug 229839] FontFaceSet.status needs to react to style changes : [Attachment 437233] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 229839: FontFaceSet.status needs to react to style changes
https://bugs.webkit.org/show_bug.cgi?id=229839

Attachment 437233: Patch

https://bugs.webkit.org/attachment.cgi?id=437233&action=review




--- Comment #5 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 437233
  --> https://bugs.webkit.org/attachment.cgi?id=437233
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437233&action=review

> Source/WebCore/css/FontFaceSet.cpp:191
> +    auto protect = m_backing;

Hm. This clearly does the right thing, but I usually like to ensure we are
actually in a Ref or RefPtr when using the protect idiom by doing something
like:

Ref protect = backing;

just to make sure that if m_backing ever changes type this is still doing what
we expect.

Since m_backing is a Ref, I guess the posibilities here are that either 'this'
got deleted or m_backing got replaced and the original value got deleted. Would
be interesting to try and add tests for either of those cases if possible.