[webkit-reviews] review granted: [Bug 229798] Use isRendererReplacedElement for SimplifiedBackwardsTextIterator : [Attachment 437151] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Frédéric Wang (:fredw)
<fred.wang at free.fr>'s request for review:
Bug 229798: Use isRendererReplacedElement for SimplifiedBackwardsTextIterator
https://bugs.webkit.org/show_bug.cgi?id=229798

Attachment 437151: Patch

https://bugs.webkit.org/attachment.cgi?id=437151&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 437151
  --> https://bugs.webkit.org/attachment.cgi?id=437151
Patch

I assume the real benefits of this fix are more indirect, for the clients of
SimplifiedBackwardsTextIterator, such as the visible boundary functions, which
presumably give us incorrect results in these cases.

It’s unfortunate that we don’t really know what those cases are and so can only
detect the improvement with a unit test of the iterator itself.