[webkit-reviews] review denied: [Bug 215379] Implement HTTPServer for API tests in c++ : [Attachment 436989] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Takashi Komori
<takashi.komori at sony.com>'s request for review:
Bug 215379: Implement HTTPServer for API tests in c++
https://bugs.webkit.org/show_bug.cgi?id=215379

Attachment 436989: Patch

https://bugs.webkit.org/attachment.cgi?id=436989&action=review




--- Comment #18 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 436989
  --> https://bugs.webkit.org/attachment.cgi?id=436989
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436989&action=review

> Tools/TestWebKitAPI/GenericConnection.h:97
> +class GenericConnection {

This is still not the unified code that should go in the repo.	In order to be
properly abstracted, this should completely replace class Connection in
HTTPServer.h and have the same interface.

> Tools/TestWebKitAPI/GenericHTTPServer.h:43
> +class GenericHTTPServer {

When this is properly abstracted, this should completely replace class
HTTPServer in HTTPServer.h and have the same interface, except the function
that returns a NSURLRequest is platform-specific.  I designed those classes to
be able to be implemented on other platforms as they are.
We also don't need "Generic" prefix on all the class names.

> Tools/TestWebKitAPI/cocoa/GenericConnectionCocoa.mm:113
> +#if 0

:(