[webkit-reviews] review granted: [Bug 232387] JSCallbackData should use lexical global object for errors and lifecycle : [Attachment 442603] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Alexey Shvayka
<ashvayka at apple.com>'s request for review:
Bug 232387: JSCallbackData should use lexical global object for errors and
lifecycle
https://bugs.webkit.org/show_bug.cgi?id=232387

Attachment 442603: Patch

https://bugs.webkit.org/attachment.cgi?id=442603&action=review




--- Comment #3 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 442603
  --> https://bugs.webkit.org/attachment.cgi?id=442603
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442603&action=review

r=me -- but please fix the visit issue before landing.

> Source/WebCore/Modules/webaudio/AudioWorkletProcessor.h:75
> +    JSValueInWrappedObject m_processCallback;

We need to visit this value inside
JSAudioWorkletProcessor::visitAdditionalChildren().