[webkit-reviews] review denied: [Bug 232077] [GTK][WPE] Use the display refresh to drive scrolling animations (sync scroll) : [Attachment 442583] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Chris Lord
<clord at igalia.com>'s request for review:
Bug 232077: [GTK][WPE] Use the display refresh to drive scrolling animations
(sync scroll)
https://bugs.webkit.org/show_bug.cgi?id=232077

Attachment 442583: Patch

https://bugs.webkit.org/attachment.cgi?id=442583&action=review




--- Comment #7 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 442583
  --> https://bugs.webkit.org/attachment.cgi?id=442583
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442583&action=review

> Source/WebCore/page/Chrome.h:99
> +    void registerActiveScrollAnimator(ScrollAnimator&) override;
> +    void serviceScrollAnimations();

It feels wrong to go via Chrome for this; Chrome is normally used to
communicate with the WebKit layer, and there should be no need to do this here.

startAnimationCallback() should be able to invoke Page-level stuff via
FrameView/RenderLayerScrollableaArea ScrollableArea subclasses.