[webkit-reviews] review granted: [Bug 232179] RemoteRenderingBackend should not send IPC in the middle of destruction : [Attachment 442240] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 232179: RemoteRenderingBackend should not send IPC in the middle of
destruction
https://bugs.webkit.org/show_bug.cgi?id=232179

Attachment 442240: Patch

https://bugs.webkit.org/attachment.cgi?id=442240&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 442240
  --> https://bugs.webkit.org/attachment.cgi?id=442240
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442240&action=review

> Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:147
> +	       m_remoteDisplayLists.set(renderingResourceIdentifier,
remoteDisplayList);

When we know the key is not already in the map, set is just a slower slightly
larger version of add. The difference is that after doing an add, set
overwrites the value if the key is already in the map. Given that, I would have
used add here.